Fix console scrolling for web #5439
Open
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listen to console container scroll and forward event to parent container
sharon-wang
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #2056
VS Code drops the wheel scroll event to prevent gesture navigation. This listens to the event on the top level element in the console and forwards the scroll to the parent container.
The fix also didn't seem to affect desktop but it seems safer to add an
isWebcheck.I suspect there may be other places that have this problem too. Going forward, it might be better to try to use the Scrollable component that uses VS Code's scrollable code and that would hopefully avoid this bug. However, Scrollable needs to know the container dimensions and the content dimensions to properly size the scroll bar.
QA Notes
I tested locally with a trackpad but the event should also be triggered for a standard mouse wheel to fix the scrolling.