Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests: fix pressplay and disable gradio test #5447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

E2E tests: fix pressplay and disable gradio test #5447

wants to merge 1 commit into from

Conversation

testlabauto
Copy link
Contributor

Await the toast(s) for press play actions and disable gradio test as it doesn't stay running on OSX and Windows.

QA Notes

All smoke tests should pass.

jonvanausdeln
jonvanausdeln approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@jonvanausdeln jonvanausdeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If you create an issue for gradio, it would be good in include that in the test comment.. and point out in the issue that we turned off the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonvanausdeln jonvanausdeln jonvanausdeln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testlabauto @jonvanausdeln