Feature/auto update package type #6026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
timtmok
force-pushed
the
feature/auto-update-package-type
branch
2 times, most recently
from
9d1ac8c to
39a43f1
Compare
Updates product.json with package type during installer prep stage
timtmok
force-pushed
the
feature/auto-update-package-type
branch
from
39a43f1 to
d720fa9
Compare
jmcphers
approved these changes
Jan 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #5538 and #5540
Modifies the Linux build to update
product.jsonwhen building the installer. Adds apackageTypeto the product configuration, available on Linux only. Windows already adds in atargetthat is eithersystemoruser.The update URLs will now check more specifically the exact installer that was used. This prepares Windows to download the correct installer for auto-updates.
Release Notes
New Features
Enables Positron to detect the type of install so that the update service knows which installer to use.
Bug Fixes
QA Notes
No noticeable changes other than the debug log on the main process should show an update url that matches the platform, arch, and install type (deb/rpm/system/user).