-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gradio support #2418
base: main
Are you sure you want to change the base?
Add Gradio support #2418
Conversation
Note that we will want to wait to merge this until the Connect release with Gradio support is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to successfully deploy the hello world example however a few things:
On the Connect side I got errors, and it didn't behave as expected. I have a theory this is because of Connect, and not necessarily Publisher, but I'll want to verify that.
Additionally I think there is a question about if we want to add this to our documentation in the state this is currently in without inspection when selecting a gradio Python file
That isn't a criticism of your work @edavidaja but a question on how to handle this PR and when to merge it / announce it.
Presumably this is either something we add here or follow on with a PR? Or am I missing something else? |
No you aren't missing anything. I just think we need to make a decision on:
|
IMO, It does not feel complete without the inspection part. Another thing to consider, how does the publisher behave when publishing a |
This is great question. Ideally what it should do is propagate the error we get back from Connect which should be meaningful about not supporting that content type. We are getting into a bit of a larger design discussion here, but from what it sounds like we should be able to merge this, but perhaps hold off on including it in the changelog until the Gradio support is complete. We could create an epic on the board to track that. |
This sounds good. Yes, in this case we definitely do not want to advertise this too heavily until it's officially added to Connect and that is released. |
Intent
Add support for deploying gradio applications.
Type of Change
Approach
Automated Tests
Added.
Directions for Reviewers
Obtain a sample gradio application and deploy it to Connect.
Checklist