Streamlit comp updates #42
Conversation
|
Any idea why there doesn't seem to be a deployment preview available? (Doesn't seem like the express example will work since shinylive doesn't have the dev version of shiny?) |
docs/helpers.py
Outdated
| def include_shiny_folder( | ||
| path: str, | ||
| file_name: str = "app.py", | ||
| exclusions: List[str] = [], | ||
| components: str = "editor, viewer", | ||
| viewer_height: str = "800", | ||
| extra_object: Any = "", | ||
| ) -> None: | ||
| print( | ||
| _include_shiny_folder( | ||
| path, file_name, exclusions, components, viewer_height, extra_object | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Feels like this should get removed (and if you want to print() for local debugging, just print(block) at the end of the function)?
There was a problem hiding this comment.
Oh this is designed to include a single shinylive app in a block. So you might want to use an app in tabs, but maybe also refer to just one version of the file in a standalone app without tabs. I added some doc strings to clarify that.
|
I think we need to build the dev version of shinylive, which Winston was going to work on. We definitely should have that for the whole transition branch so we can look for bugs. |
|
@gshotwell I just realized the Maybe it would make sense to use the reuse infrastructure in #66 here as well? I think this article will also need some updates to reflect recent changes in Express, like |
|
@gshotwell just a heads up, I made some fixes and updates in e3bca01. |
|
@cpsievert your changes look good, I pushed a couple of fixes to avoid duplicate "Since," sentences. I think the best thing to do is merge #66, then I'll refactor this to use that pattern. |
There was a problem hiding this comment.
helpers.py looks great! I made a few suggestions to take advantage of the patterns in #66.
Also worth considering that we can use py-shinylive to create shinylive URLs or to manage the shinylive bundles as needed. There are semi-internal helpers that we could build on (as the need arises). See posit-dev/py-shinylive#20
Co-authored-by: Garrick Aden-Buie <[email protected]>
gshotwell
changed the base branch from
shiny-express-transition
to
rc-express
* rc-express: (85 commits) sort imports define Sequence Streamlit comp updates (#42) chore: quarto add shafayetShafee/line-highlight tweak line highlight styles Get .app-preview and other styles into whole site Make `shiny-mode-tab` and `shinylive` links in code block site-wide features update shinylive links use `@render.display` init tooltip on shinylive edit link use javascript to add the shinylive link default viewerHeight shouldn't include px quarto doesn't play well with fading tabsets update shinylive links migration/qmd update script tweak action-link preview app stacked preview/code Start 'rc-express' branch with latest py-shiny bump py-shiny version expressify components/outputs/verbatim-text ...
This updates the streamlit-comparisson article to use shiny express.
TODO: