Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix erroneous trailing combinators in pseudos #294

Conversation

romainmenke
Copy link
Contributor

:is(.bar /* comment 3 */ ) would produce: TAG COMBINATOR inside the :is().
While the /* comment 3 */ is actually just meaningless whitespace and comments.

Adding ) to the list of tokens when checking for the end of a selector fixes this issue

@alexander-akait alexander-akait merged commit fb38876 into postcss:master Aug 12, 2024
4 checks passed
@romainmenke romainmenke deleted the fix-erroneous-trailing-combinators-in-pseudos--reliable-snapping-turtle-acedb7c68c branch August 12, 2024 10:42
@romainmenke
Copy link
Contributor Author

Thank you @alexander-akait 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants