Deprecate redundant bundled libraries #1050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appurva21
changed the base branch from
develop
to
feature/use-native-atob-btoa
appurva21
force-pushed
the
feature/deprecate-redundant-libs
branch
from
62aa4c7
to
91365d2
Compare
appurva21
commented
Sep 24, 2024
| 'postman.clearGlobalVariables': 'pm.globals.clear()', | ||
| 'postman.clearGlobalVariable': 'pm.globals.unset()', | ||
| 'postman.getResponseCookie': 'pm.cookies.get()', | ||
| 'postman.getResponseHeader': 'pm.response.headers.get()' |
There was a problem hiding this comment.
Diff due to addition of ""
appurva21
commented
Sep 24, 2024
| responseBody: '"pm.response.text()"', | ||
| iteration: '"pm.info.iteration"', | ||
| _: '"require(\'lodash\')"', | ||
| CryptoJS: 'global "crypto" object', |
There was a problem hiding this comment.
- Removed alternative for Backbone as the lib is itself deprecated now
- Update alternative for CryptoJS
appurva21
force-pushed
the
feature/use-native-atob-btoa
branch
from
b53b441
to
0dcb698
Compare
appurva21
force-pushed
the
feature/deprecate-redundant-libs
branch
from
91365d2
to
f7e8378
Compare
appurva21
force-pushed
the
feature/use-native-atob-btoa
branch
from
0dcb698
to
4505c79
Compare
appurva21
force-pushed
the
feature/deprecate-redundant-libs
branch
from
f7e8378
to
4d1e196
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/use-native-atob-btoa #1050 +/- ##
===============================================================
Coverage ? 52.77%
===============================================================
Files ? 12
Lines ? 612
Branches ? 146
===============================================================
Hits ? 323
Misses ? 249
Partials ? 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Deprecate following libraries in favour of better alternatives:
atob: native atob functionbtoa: native btoa functioncrypto-js: native crypto objecttv4:ajvbackbone: 👋