Enhance pm.vault API with improved get and set methods #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appurva21
requested changes
Oct 22, 2024
| @@ -33,11 +33,11 @@ class Vault { | |||
| const getVaultInterface = (vault) => { | |||
| return { | |||
| get: (key) => { | |||
| return vault('get', key); | |||
| return vault('get', key).then((value) => { return (value === null ? undefined : value); }); | |||
There was a problem hiding this comment.
Why is this coming null in the first place? This looks like a patch rather than fixing the root cause
| }, | ||
|
|
||
| set: (key, value) => { | ||
| return vault('set', key, value); | ||
| return vault('set', key, value).then(() => { return value; }); |
There was a problem hiding this comment.
Why are we making this change?
.set returns undefined for other variable scopes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the pm.vault API to enhance its functionality and improve type safety.
The main changes are: