ensured the log block finishes in test helper requests #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log block is wrapped with a parent proc that reports completion of the original log block. After issuing test requests, we terminate the EM server only after the log block is complete, or if we checked on the log block more than a user-definable number of times.
| @log_block_checks ||= 0 | ||
| @log_block_checks += 1 | ||
|
|
||
| if log_block_complete? || @log_block_checks > @max_log_block_checks |
There was a problem hiding this comment.
Perhaps we should raise if we hit @max_log_block_checks?
|
Honestly, this feels like a hack. We're working around the missing functionality in EM when it should really be in EM. This seems like the kind of thing people would be interested in generally. |
|
Fair enough, I'll raise an issue in eventmachine. |
|
I've posted an issue to eventmachine . . and I found a bug in some edge cases. Closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242