Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more, hopefully rather uncontroversial simplifications #172

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add more, hopefully rather uncontroversial simplifications #172

wants to merge 7 commits into from

Conversation

teiesti
Copy link
Collaborator

@teiesti teiesti commented Dec 4, 2024

This is the first follow-up for #164. It groups all the "easy" and therefore rather "uncontroversial" simplifications.

@teiesti teiesti added E-easy Experience: Easy C-feature-accepted Category: Accepted feature L-fol Language: First-order logic A-simplifying Area: Simplifying labels Dec 4, 2024
@teiesti teiesti requested a review from ZachJHansen December 4, 2024 22:31
@teiesti
Copy link
Collaborator Author

teiesti commented Dec 4, 2024

@ZachJHansen You can review and merge this whenever you like. I do not indent to add more to this. All other simplifications will go into other PRs.

ZachJHansen
ZachJHansen requested changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@ZachJHansen ZachJHansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, except I would prefer that each change in apply_definitions be a separate function so we can choose to apply them independently. Also, it would be nice to support a transformation from "F -> #false" to "not F" as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZachJHansen ZachJHansen ZachJHansen requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A-simplifying Area: Simplifying C-feature-accepted Category: Accepted feature E-easy Experience: Easy L-fol Language: First-order logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teiesti @ZachJHansen