forked from apache/airflow
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AIP-72: Allow retrieving Connection from Task Context (apache#45043)
part of apache#44481 - Added a minimal Connection user-facing object in Task SDK definition for use in the DAG file - Added logic to get Connections in the context. Fixed some bugs in the way related to Connection parsing/serializing! Now, we have following Connection related objects: - `ConnectionResponse` is auto-generated and tightly coupled with the API schema. - `ConnectionResult` is runtime-specific and meant for internal communication between Supervisor & Task Runner. - `Connection` class here is where the public-facing, user-relevant aspects are exposed, hiding internal details. **Next up**: - Same for XCom & Variable - Implementation of BaseHook.get_conn Tested it with a DAG: <img width="1711" alt="image" src="https://github.com/user-attachments/assets/14d28fb7-f6c5-4fbe-b226-46873af2d0f3" /> DAG: ```py from __future__ import annotations from airflow.models.baseoperator import BaseOperator from airflow.models.dag import dag class CustomOperator(BaseOperator): def execute(self, context): import os os.environ["AIRFLOW_CONN_AIRFLOW_DB"] = "sqlite:///home/airflow/airflow.db" task_id = context["task_instance"].task_id print(f"Hello World {task_id}!") print(context) print(context["conn"].airflow_db) assert context["conn"].airflow_db.conn_id == "airflow_db" @dag() def super_basic_run(): CustomOperator(task_id="hello") super_basic_run() ``` For case where a **connection is not found** <img width="1435" alt="image" src="https://github.com/user-attachments/assets/7c5e0cb4-6ed4-41aa-9a57-e5641adce954" />
- Loading branch information
Showing
11 changed files
with
373 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
from __future__ import annotations | ||
|
||
import attrs | ||
|
||
|
||
@attrs.define | ||
class Connection: | ||
""" | ||
A connection to an external data source. | ||
:param conn_id: The connection ID. | ||
:param conn_type: The connection type. | ||
:param description: The connection description. | ||
:param host: The host. | ||
:param login: The login. | ||
:param password: The password. | ||
:param schema: The schema. | ||
:param port: The port number. | ||
:param extra: Extra metadata. Non-standard data such as private/SSH keys can be saved here. JSON | ||
encoded object. | ||
""" | ||
|
||
conn_id: str | ||
conn_type: str | ||
description: str | None = None | ||
host: str | None = None | ||
schema: str | None = None | ||
login: str | None = None | ||
password: str | None = None | ||
port: int | None = None | ||
extra: str | None = None | ||
|
||
def get_uri(self): ... | ||
|
||
def get_hook(self): ... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
from __future__ import annotations | ||
|
||
from typing import TYPE_CHECKING, Any | ||
|
||
import structlog | ||
|
||
from airflow.sdk.exceptions import AirflowRuntimeError, ErrorType | ||
|
||
if TYPE_CHECKING: | ||
from airflow.sdk.definitions.connection import Connection | ||
from airflow.sdk.execution_time.comms import ConnectionResult | ||
|
||
|
||
def _convert_connection_result_conn(conn_result: ConnectionResult): | ||
from airflow.sdk.definitions.connection import Connection | ||
|
||
# `by_alias=True` is used to convert the `schema` field to `schema_` in the Connection model | ||
return Connection(**conn_result.model_dump(exclude={"type"}, by_alias=True)) | ||
|
||
|
||
def _get_connection(conn_id: str) -> Connection: | ||
# TODO: This should probably be moved to a separate module like `airflow.sdk.execution_time.comms` | ||
# or `airflow.sdk.execution_time.connection` | ||
# A reason to not move it to `airflow.sdk.execution_time.comms` is that it | ||
# will make that module depend on Task SDK, which is not ideal because we intend to | ||
# keep Task SDK as a separate package than execution time mods. | ||
from airflow.sdk.execution_time.comms import ErrorResponse, GetConnection | ||
from airflow.sdk.execution_time.task_runner import SUPERVISOR_COMMS | ||
|
||
log = structlog.get_logger(logger_name="task") | ||
SUPERVISOR_COMMS.send_request(log=log, msg=GetConnection(conn_id=conn_id)) | ||
msg = SUPERVISOR_COMMS.get_message() | ||
if isinstance(msg, ErrorResponse): | ||
raise AirflowRuntimeError(msg) | ||
|
||
if TYPE_CHECKING: | ||
assert isinstance(msg, ConnectionResult) | ||
return _convert_connection_result_conn(msg) | ||
|
||
|
||
class ConnectionAccessor: | ||
"""Wrapper to access Connection entries in template.""" | ||
|
||
def __getattr__(self, conn_id: str) -> Any: | ||
return _get_connection(conn_id) | ||
|
||
def __repr__(self) -> str: | ||
return "<ConnectionAccessor (dynamic access)>" | ||
|
||
def __eq__(self, other): | ||
if not isinstance(other, ConnectionAccessor): | ||
return False | ||
# All instances of ConnectionAccessor are equal since it is a stateless dynamic accessor | ||
return True | ||
|
||
def get(self, conn_id: str, default_conn: Any = None) -> Any: | ||
try: | ||
return _get_connection(conn_id) | ||
except AirflowRuntimeError as e: | ||
if e.error.error == ErrorType.CONNECTION_NOT_FOUND: | ||
return default_conn | ||
raise |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.