fix incoming handler issue #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hulkoba , thanks for putting this together. Can you write a PR description and add a test to prove the desired functionality? |
to fix the tests which are failing because incoming is called twice for put and bulkDocs
hulkoba
commented
Jul 2, 2021
| @@ -38,7 +38,7 @@ | |||
| "lie": "3.0.4", | |||
| "pouchdb-extend": "0.1.2", | |||
| "pouchdb-promise": "5.4.3", | |||
| "pouchdb-wrappers": "4.1.0", | |||
| "pouchdb-wrappers": "https://github.com/neighbourhoodie/pouchdb-wrappers.git#mergemaster", | |||
There was a problem hiding this comment.
This is a fix for #55. Maybe there will be an update soon
hulkoba
force-pushed
the
fix_incoming_handler_issue
branch
from
c5e7903 to
d368a9f
Compare
hulkoba
force-pushed
the
fix_incoming_handler_issue
branch
from
991d04f to
611767a
Compare
|
This looks good to me! Tests pass and everything. |
This was referenced Jul 21, 2021
|
hey @nolanlawson , @tlvince @AdrianoFerrari any chance you could take a look? Thanks. |
|
This was merged as a result of us merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #8
closes #54
Transform-Pouch wraps the
.bulkDocs()method of PouchDB in order to apply its incoming handler.For most adapters this is fine, but PouchDB will use an adapter's
._put()method on calls to.put()if it has one.PouchDB's HTTP adapter -- that is, the one that connects to CouchDB directly -- does specify a
._put()method, and as a result Transform-Pouch's incoming handler does not run when connecting directly to CouchDB.This PR also