Add PhantomBusInteraction
#2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
commented
Dec 2, 2024
georgwiese
commented
Dec 2, 2024
|
The following test seems to fail. Witgen ends in an infinite loop after the loop is detected in the main machine: export TEST=sum
cargo run -r --features plonky3 --bin powdr-rs compile riscv/tests/riscv_data/$TEST -o output --max-degree-log 15 --field gl
cargo run -r --features plonky3 pil output/$TEST.asm -o output -f --field gl --prove-with mock --linker-mode bus -i 1,1,1Looks like removing the bus interaction fixes it. Gotta debug tomorrow. |
|
The commit above fixes the bug. |
Schaeff
reviewed
Dec 4, 2024
| @@ -313,6 +315,7 @@ impl<'a, T: FieldElement> MachineExtractor<'a, T> { | |||
| } | |||
| Identity::Polynomial(i) => self.fixed.polynomial_references(i), | |||
| Identity::Connect(i) => self.fixed.polynomial_references(i), | |||
| Identity::PhantomBusInteraction(i) => self.fixed.polynomial_references(&i.tuple), | |||
There was a problem hiding this comment.
Just double checking we only need to visit the tuple?
There was a problem hiding this comment.
Right, I should add the multiplicity! I thought it was handled elsewhere, but it is also added when processing lookups. Good catch!
Schaeff
approved these changes
Dec 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Builds on #2194 and #2183. This PR gives us (relatively) fast witness generation for the bus, by writing custom code instead of relying on the generic solver + prover functions: ``` $ cargo run -r --features plonky3 --bin powdr-rs compile riscv/tests/riscv_data/keccak-o output --max-degree-log 18 --field gl $ cargo run -r --features plonky3 pil output/$TEST.asm -o output -f --field gl --prove-with mock --linker-mode bus ... Running main machine for 262144 rows [00:00:05 (ETA: 00:00:05)] █████████░░░░░░░░░░░ 48% - 24283 rows/s, 3169k identities/s, 92% progress Found loop with period 1 starting at row 127900 [00:00:05 (ETA: 00:00:00)] ████████████████████ 100% - 151125 rows/s, 16170k identities/s, 100% progress Witness generation took 5.748081s Writing output/commits.bin. Backend setup for mock... Setup took 0.54769236s Generating later-stage witnesses took 0.29s Proof generation took 2.0383847s ``` On `main`, second-stage witgen for the main machine alone takes about 5 minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Constr:: PhantomBusInteractionvariant. For now, it is ignored - if users want to use a bus, they need to express this in terms of phantom lookups / permutations as before this PR.I added a few
TODO(bus_interaction)and opened #2184 to track support for phantom bus interactions.One use-case this could have before though is to trigger a "hand-written" witness generation for the bus, as discussed in the chat.