[WIP] Remove acc_next columns
#2200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
force-pushed
the
bus-witgen
branch
from
b3a3169 to
98e22ba
Compare
|
has conflicts |
leonardoalt
reviewed
Dec 9, 2024
| @@ -68,6 +66,8 @@ impl<F: FieldElement> Connection<F> { | |||
| | Identity::PhantomPermutation(PhantomPermutationIdentity { left, right, .. }) => { | |||
| Ok((left.clone(), right.clone(), ConnectionKind::Permutation)) | |||
| } | |||
| // TODO(bus_interaction) | |||
|
somehow the diff here is showing repeated diffs even though this PR builds on top of the other two, so it's gonna be easier when this is rebased |
georgwiese
force-pushed
the
bus-witgen
branch
from
98e22ba to
230f2f5
Compare
georgwiese
force-pushed
the
remove-acc-next
branch
from
ce2e6f1 to
cded201
Compare
leonardoalt
previously approved these changes
Dec 9, 2024
|
Part of #2201 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the custom witgen in #2191, we don't actually need it anymore!