chore: optimize the useStatus hook and underlying isEqual #438
Conversation
🦋 Changeset detectedLatest commit: 9d6b31b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| statusChanged: (newStatus) => { | ||
| setSyncStatus(prev => { | ||
| // Only update if the status is actually different | ||
| return prev.isEqual(newStatus) ? prev : newStatus |
There was a problem hiding this comment.
The isEqual check should already be implemented here which should only cause the statusChanged listeners to be fired if the status actually changed. Is this necessary? If so there might be a different bug elsewhere.
There was a problem hiding this comment.
From my experience, when I use the useStatus hook from powersync my app refreshes every 5 seconds even if the status has not actually changed
There was a problem hiding this comment.
@Frank-vdm I tried to reproduce the sync status hook updating periodically with no actual sync status changes or to see if the statusChanged listener was being fired when there was infact no change, but I could not really reproduce this. The only time I could (unreliably) reproduce was when making changes to the usePowerSyncStatus hook code and hot reloading the application - which seems like an edge case which would not happen for users of the SDK.
Do you perhaps have any more information on how to reproduce this?
This prevents the 'spammy' useStatus behaviour
key changes:
JSON.stringifyalternative this is important since this is triggered often