Capability to mix connection and disconnection in a single update (#896)

Signed-off-by: Geoffroy Jamgotchian <[email protected]>
powsybl · Nov 28, 2024 · 6c4c84e · 6c4c84e
1 parent 43535cc
commit 6c4c84e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/java/src/main/java/com/powsybl/dataframe/network/NetworkDataframes.java b/java/src/main/java/com/powsybl/dataframe/network/NetworkDataframes.java
@@ -1269,7 +1269,9 @@ private static <T extends Injection<T>> Function<T, String> getBusBreakerViewBus
     }
 
     private static void setBusBreakerViewBusId(Terminal t, String busId) {
-        Objects.requireNonNull(t).getBusBreakerView().setConnectableBus(busId);
+        if (!busId.isEmpty()) {
+            Objects.requireNonNull(t).getBusBreakerView().setConnectableBus(busId);
+        }
     }
 
     private static <T extends Injection<T>> void setBusBreakerViewBusId(T i, String busId) {

diff --git a/tests/test_network.py b/tests/test_network.py
@@ -2487,5 +2487,16 @@ def test_deprecated_operational_limits_element_type_kwargs():
                                           acceptable_duration=[-1, 60], fictitious=[False, True])
 
 
+def test_connect_disconnect_with_empty_bus():
+    network = pp.network.create_eurostag_tutorial_example1_with_more_generators_network()
+    network.update_generators(id=['GEN', 'GEN2'], connected=[False, True], bus_breaker_bus_id=['', 'NGEN'])
+    generators = network.get_generators(attributes=['connected', 'bus_breaker_bus_id'])
+    expected_generators = pd.DataFrame(index=pd.Series(name='id', data=['GEN', 'GEN2']),
+                            columns=['connected', 'bus_breaker_bus_id'],
+                            data=[[False, 'NGEN'],
+                                  [True, 'NGEN']])
+    pd.testing.assert_frame_equal(expected_generators, generators, check_dtype=False)
+
+
 if __name__ == '__main__':
     unittest.main()