Set compatibility mode for native image build option #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <[email protected]>
EtienneLt
force-pushed
the
change-to-compatibility-mode-for-graalvm
branch
from
f6ea9f3 to
7311d87
Compare
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
geofjamg
changed the title
geofjamg
approved these changes
Oct 23, 2023
Signed-off-by: EtienneLt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When running on some Linux system, we get error:
This is because the default
marchvalue for native image expect the code to be running on a machine with exactly the same processor features.What is the new behavior (if this is a feature change)?
We use compatibility mode for
march. Performance impact seems to be like 10% slower which is ok to get a better portability of the wheel.Does this PR introduce a breaking change or deprecate an API?
Other information: