Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voltage level topology kind update #883

Merged
merged 12 commits into from
Jan 8, 2025
Merged

Voltage level topology kind update #883

merged 12 commits into from
Jan 8, 2025

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Nov 6, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the new behavior (if this is a feature change)?
We can convert a node/breaker topology model to a bus/breaker one.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@@ -68,6 +68,7 @@ public static void setException(PyPowsyblApiHeader.ExceptionHandlerPointer excep
// we need to create a non null message as on C++ side a null message is considered as non exception to rethrow
// typically a NullPointerException has a null message and an empty string message need to be set in order to
// correctly handle the exception on C++ side
t.printStackTrace();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes a security issue in sonar, is it meant to be used only for debug or to keep it in the PR ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now ready for review!

Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg geofjamg changed the title [WIP] Voltage level topology kind update Voltage level topology kind update Jan 7, 2025
@geofjamg geofjamg requested a review from HugoKulesza January 7, 2025 12:47
Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link

sonarqubecloud bot commented Jan 7, 2025

@HugoKulesza HugoKulesza merged commit 274902c into main Jan 8, 2025
9 checks passed
@HugoKulesza HugoKulesza deleted the update_topology_kind branch January 8, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants