Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get element type from a node/breaker topo nodes dataframe #910

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Dec 9, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

Whe getting a node/breaker topo, nodes dataframe, we only have the element IDs.

What is the new behavior (if this is a feature change)?
We now have in addition to element IDs, the elements types.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@geofjamg geofjamg requested a review from HugoKulesza December 9, 2024 15:56
Copy link

sonarqubecloud bot commented Dec 9, 2024

Copy link

sonarqubecloud bot commented Dec 9, 2024

@HugoKulesza HugoKulesza merged commit 9f49009 into main Dec 10, 2024
9 checks passed
@HugoKulesza HugoKulesza deleted the node_breaker_topo_element_type branch December 10, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants