Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency: Created build script and build_info.json for Pyodbc #4822

Closed
wants to merge 3 commits into from
Closed

Currency: Created build script and build_info.json for Pyodbc #4822

wants to merge 3 commits into from

Conversation

Harithanagothu2
Copy link
Contributor

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

@Harithanagothu2 Harithanagothu2 marked this pull request as ready for review November 26, 2024 07:22
shubham-dayma-ibm
shubham-dayma-ibm requested changes Nov 26, 2024
View reviewed changes
p/pyodbc/pyodbc_ubi_9.3.sh
echo "$PACKAGE_URL $PACKAGE_NAME"
echo "$PACKAGE_NAME | $PACKAGE_URL | $PACKAGE_VERSION | GitHub | Fail | Install_Fails"
exit 1
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no test cases to execute?

Copy link
Contributor Author

@Harithanagothu2 Harithanagothu2 Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have testcases, but same testcases are failing in power and x_86.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to run the test suit and keep fail test coding block

@Harithanagothu2 Harithanagothu2 marked this pull request as draft December 18, 2024 07:08
@Harithanagothu2
Copy link
Contributor Author

This package has already been merged, so this pull request is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-dayma-ibm shubham-dayma-ibm shubham-dayma-ibm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Harithanagothu2 @shubham-dayma-ibm