Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken empty repository view #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

DeX77
Copy link

@DeX77 DeX77 commented Jan 26, 2011

Guess this is a typical off-by-one error

@nakchak
Copy link

nakchak commented Feb 10, 2011

The fix didnt work for me, although i was having issues with Svn::Error::FsNotFound on a repository created after 200th revision.

Simply added a rescue Svn::Error::FsNotFound to the rescue block on the revisions method, which seems to have fixed the issue for me

@DeX77
Copy link
Author

DeX77 commented Feb 10, 2011

Thx for trying it! I'm sorry to hear it didn't help. Anyway I think your issue might not be related to my change?
To ignore Errors doesn't sound like the way to go for me, either.

@nakchak
Copy link

nakchak commented Feb 10, 2011

I agree, i would rather handle it annother way, but the root of my problem came from how the repository is structured, as we have about 50 projects running out of one repo, so "root" project folders often have an initial revision number of several thousand when they are new projects in the repo. Initially i was seeing the problem with an empty folder hence trying the fix.

Given how the libsvn plugin is called from the core repo interface code, it would be impractical to modify core functionality to work with a reverse log rather than iterating from 1 to head revision for a given project, so in this case catching the FsNotFound seems an acceptable solution, also would seem to fix a lot of the issues posted here regarding server 500 errors, as i assume many people use svn in a similar manner to how its been set up where i work. Hopefully i can push through the adoption of the model used by collabnet subversion edge, which uses the repo per project structure. But right now that isnt an option.

Nice DoTT avatar btw :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants