Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Android with non-maui workflow #30747

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo changed the title Make android build on non-maui workflow Build Android with non-maui workflow Nov 18, 2024
@bdach
Copy link
Collaborator

bdach commented Nov 18, 2024

and our workflows started intermittently failing since

At least in the ones you've linked in the OP, all failures are on the newer github runner image (this is visible if you "download raw logs").

@peppy
Copy link
Member

peppy commented Nov 18, 2024

Confirms my AB testing runners on live theory 👍

@peppy peppy enabled auto-merge November 18, 2024 08:39
@bdach
Copy link
Collaborator

bdach commented Nov 18, 2024

Um... the android action failed here. And it's already supposedly getting the "correct" non-maui one. So I think this is a swing and a miss, unfortunately...

@bdach bdach disabled auto-merge November 18, 2024 08:40
@smoogipoo
Copy link
Contributor Author

smoogipoo commented Nov 18, 2024

Well... At least that's two more data points because this same commit passed on my fork. Will report even further upstream.

Edit: nvm it didn't pass on my fork

Though I believe this is still fine to merge in, the ios build already uses non-maui so if anything this is standardising it.

@bdach
Copy link
Collaborator

bdach commented Nov 18, 2024

Actually you know what, I believe there used to be something weird in the past wherein the changes don't actually take effect until they're in master, so maybe the UI is just confused somehow...? Dunno. Let's try and get this in I guess 🤷

@bdach bdach enabled auto-merge November 18, 2024 08:56
@bdach
Copy link
Collaborator

bdach commented Nov 18, 2024

Nah framework is on android and not maui-android and still breaks, so my hopes aren't high.

@smoogipoo
Copy link
Contributor Author

smoogipoo commented Nov 18, 2024

Worst case we can rollback the sdk or workflow so not all is lost. Not too important for now regardless since we have an existing mostly-up-to-date build, will just report upstream and figure it out if it isn't f fixed by next time.

@bdach bdach merged commit 28fb0bf into ppy:master Nov 18, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants