Improve multiplayer room status handling #30838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
force-pushed
the
better-room-status
branch
from
3638aa3
to
1b8db7c
Compare
bdach
reviewed
Nov 25, 2024
| @@ -29,18 +29,27 @@ protected override void LoadComplete() | |||
| base.LoadComplete(); | |||
|
|
|||
| room.PropertyChanged += onRoomPropertyChanged; | |||
|
|
|||
| Scheduler.AddDelayed(updateRoomStatus, 5000, true); | |||
There was a problem hiding this comment.
Just to confirm intent - are these schedules supposed to handle the passage of time in relation to EndDate in order to correctly transition to ended state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereqs:
Roommodel #30830Aside from refactoring the weirdness that is the existing
RoomStatusabstract class and deserialisation process, it also makes thePlayingstate work in the lounge which is a missing feature from osu!stable.2024-11-22.20-58-07.mp4