Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix discord "view beatmap" button being shown when editing and hide identifiable information is set #30848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix discord "view beatmap" button being shown when editing and hide identifiable information is set #30848

wants to merge 1 commit into from
+3 −1

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Nov 23, 2024

frenzibyte
frenzibyte requested changes Nov 23, 2024
View reviewed changes
Copy link
Member

@frenzibyte frenzibyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine otherwise I guess.

osu.Desktop/DiscordRichPresence.cs
if (getBeatmapID(activity.Value) is int beatmapId && beatmapId > 0)
if (getBeatmapID(activity.Value) is int beatmapId
&& beatmapId > 0
&& !(activity.Value is UserActivity.EditingBeatmap && hideIdentifiableInformation))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is back-to-front coding, UserActivity should expose a method for this rather than hardcoding the types in here. E.g. ShowsBeatmapInfo(bool hideIdentifiableInformation = false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenzibyte frenzibyte frenzibyte requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size/XS type:online
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joehuu @frenzibyte