Delay back button appearance when performing a quick restart #30863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Nov 25, 2024
Comment on lines
+1593
to
+1596
| if (newOsuScreen.AllowBackButton) | ||
| ((IBindable<Visibility>)BackButton.State).BindTo(newOsuScreen.BackButtonState); | ||
| else | ||
| BackButton.Hide(); |
There was a problem hiding this comment.
Why do AllowBackButton and BackButtonState coexist? So now you have to both AllowBackButton and also set a valid BackButtonState? I guess you made up for it by setting BackButtonState to visible but like... why have 2 virtuals for essentially the same thing?
Can we not have just one?
|
Maybe even the above is too complex and the back button should just not show on the player loader. Dunno. Will need @peppy's opinion to proceed. |
|
The original rationale from me was that if loading takes too long, the player needs an out (even if they don't have a keyboard). I haven't looked into the code here yet but the premise of delaying it for the same delay as the metadata is sound enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for the
BackButtonStateproperty seems to be too much work for not much benefit, but I can add one if insisted.Note that I've created another bindable for this rather than turning
AllowBackButtonitself into a bindable, this is because we still want to allow the user to exit right after performing a quick restart (since exiting is controlled byAllowBackButton, meanwhile the new bindable only affects the visual state of the button itself).Preview:
CleanShot.2024-11-24.at.05.38.50.mp4