Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBMC: Add specs + proofs for poly_cbd_eta{1,2} #313

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

hanno-becker
Copy link
Contributor

This commit adds proofs of type safety, memory safety, and output bounds for poly_cbd_eta1 and poly_cbd_eta2.

Resolves #309

@hanno-becker hanno-becker marked this pull request as ready for review November 2, 2024 20:05
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanno-becker.
Either you got the bounds wrong, or I do not understand ARRAY_IN_BOUNDS correctly. I thought ARRAY_IN_BOUNDS has inclusive bounds. If that is the case you are off by one.

mlkem/cbd.c Outdated Show resolved Hide resolved
mlkem/cbd.c Outdated Show resolved Hide resolved
mlkem/cbd.c Outdated Show resolved Hide resolved
mlkem/cbd.c Outdated Show resolved Hide resolved
mlkem/cbd.h Outdated Show resolved Hide resolved
mlkem/cbd.h Outdated Show resolved Hide resolved
This commit adds proofs of type safety, memory safety,
and output bounds for poly_cbd_eta1 and poly_cbd_eta2.

Resolves #309

Signed-off-by: Hanno Becker <[email protected]>
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks.

@mkannwischer mkannwischer merged commit 4096d49 into main Nov 4, 2024
27 checks passed
@mkannwischer mkannwischer deleted the cbmc_poly_cbd branch November 4, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CBMC: State and prove spec for poly_cbd_eta1 and poly_cbd_eta2
2 participants