Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

totp issuer can be optional #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@tommie
Copy link

tommie commented Oct 15, 2024

I agree with your reading of the specs.

What is the point of making it a pointer, rather than just treating the empty string as missing? Is there any time the empty-string issuer would make sense?

@yogo1212
Copy link

good find!

could you separate the whitespace fixes from the feature? (in a second commit)

i also agree that using the empty string might be the better idea but i don't really mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants