-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jet Stirred Reactor (JSR) #126
Open
skrsna
wants to merge
22
commits into
pr-omethe-us:main
Choose a base branch
from
comocheng:JSR
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+562
−131
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
72d3d12
Included species profile schema
anthonymstohr 50edfc0
Added example JSR file as test case. Incomplete
anthonymstohr 1a51a63
Fixed test file errors and made schemas more compatiable with desired…
anthonymstohr 956a7fc
Updated JSR test file after autoscience meeting
anthonymstohr 7c42f17
Fixed temperature JSR schema to match test file
anthonymstohr 0d5a473
cleaned up anthony's test jsr yaml
6f55f8d
added a csv file for test jsr yaml
6220857
Undo removing part of chemked_schema.yaml
ced3ea8
Changed Datapoint to IgnitionDatapoint
4ff9c58
deleted broken jsr schemas so pytests works
a0cda57
Move process_quantity method to superclass DataPoint
rwest f87edef
Tweak docstrings
rwest 1902bfe
Putting uncertainties on a pressure
rwest 78a41a7
Hopefully, a way to read data from CSV files
rwest 97879a9
ChemKED class now successfully readstemperature column from jsr yaml
4231b2d
updated ChemKED class to read inlet and outlet compositions
ddc8cd5
fix PEP8 and indenting
sevyharris 65da379
set SpeciesProfileDataPoint to a single reaction setting
sevyharris 09bd13a
process one row at a time instead of the whole column for every datap…
sevyharris a523973
updated class docstrings
sevyharris 463bb41
added JSR to changelog
sevyharris b6da445
updated old tests so they pass again
sevyharris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Hopefully, a way to read data from CSV files
- Loading branch information
commit 78a41a724fb2b16751759467693c95fb68db4403
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no f-strings in python 3.5, which travis includes?