Kubernetes name length fix

practo · May 17, 2021 · 0be3d5d · 0be3d5d
1 parent f8c34cb
commit 0be3d5d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/controllers/batcher_deployment.go b/controllers/batcher_deployment.go
@@ -310,7 +310,7 @@ func NewBatcher(
 	if err != nil {
 		return nil, err
 	}
-	objectName := fmt.Sprintf("%s-%s", name, hash)
+	objectName := applyKubernetesNameLength(name, hash)
 	labels := getDefaultLabels(
 		BatcherLabelInstance, sinkGroup, objectName, rsk.Name,
 	)

diff --git a/controllers/loader_deployment.go b/controllers/loader_deployment.go
@@ -333,7 +333,7 @@ func NewLoader(
 	if err != nil {
 		return nil, err
 	}
-	objectName := fmt.Sprintf("%s-%s", name, hash)
+	objectName := applyKubernetesNameLength(name, hash)
 	labels := getDefaultLabels(
 		LoaderLabelInstance, sinkGroup, objectName, rsk.Name,
 	)

diff --git a/controllers/util.go b/controllers/util.go
@@ -161,6 +161,14 @@ func sortStringSlice(t []string) {
 	sort.Sort(sort.StringSlice(t))
 }
 
+func applyKubernetesNameLength(name, hash string) string {
+	if len(name) <= 55 {
+		return fmt.Sprintf("%s-%s", name, hash)
+	}
+
+	return fmt.Sprintf("%s-%s", name[:55], hash)
+}
+
 // getDefaultLabels gives back the default labels for the crd resources
 func getDefaultLabels(
 	instance, sinkGroup, objectName string,