-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Dynamic <script> tags from widget definitions, and make the whole thing work with inline fields. #23
Open
martyzz1
wants to merge
8
commits into
praekelt:develop
Choose a base branch
from
martyzz1:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyzz1
changed the title
Fix broken display strings in results not following unicode or str
Remove Dynamic <script> tages from widget definitions, and make the whole thing work with inline fields.
May 11, 2018
martyzz1
changed the title
Remove Dynamic <script> tages from widget definitions, and make the whole thing work with inline fields.
Remove Dynamic <script> tags from widget definitions, and make the whole thing work with inline fields.
May 11, 2018
Thanks! I'll test it locally as soon as possible and do the merge. |
I've found an issue with the plugin when deploying with whitenoise. The CSS
references image files which aren't in the project. That throws an
exception...
Trying to decide if they're needed.. can you shed any light?
…On Mon, 14 May 2018, 13:38 Hedley Roos, ***@***.***> wrote:
Thanks! I'll test it locally as soon as possible and do the merge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABhvSwduqamVTPIO0jm0sBqdcQ5wXtl-ks5tyXq4gaJpZM4T7yYe>
.
|
This reverts commit 351f20e.
This versions now seems to work happily with Whitenoise... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't test the AutoCompleteMultipleWidget but I've converted it as best as I can tell. But any help testing it would be appreciated...
I've tested the AutoCompleteWidget, and it works
I'll push an update to the docs, there's no need to install the scripts by overridding admin templates now