[WIP]: HEALTHCHECK-based container readiness test #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #80 +/- ##
===========================================
- Coverage 100% 99.69% -0.31%
===========================================
Files 26 29 +3
Lines 2565 2612 +47
Branches 162 167 +5
===========================================
+ Hits 2565 2604 +39
- Misses 0 4 +4
- Partials 0 4 +4
Continue to review full report at Codecov.
|
jerith
reviewed
Oct 15, 2018
| # Close the stream's underlying response object (if it has one) to | ||
| # avoid potential socket leaks. | ||
| if hasattr(stream, '_response'): | ||
| stream._response.close() |
There was a problem hiding this comment.
Shouldn't we close the stream here?
jerith
reviewed
Oct 15, 2018
| except TimeoutError: | ||
| raise TimeoutError( | ||
| "Timed out waiting for 'health_status' event with status '{}'" | ||
| .format(status)) |
There was a problem hiding this comment.
Should pass the timeout message to stream_timeout instead of catching and throwing? That would reduce boilerplate, but also add the timeout machinery to the stack trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.