FIX Review Changes (#61)

prateekmedia · Oct 15, 2023 · 0329a85 · 0329a85
1 parent b68347f
commit 0329a85
Show file tree

Hide file tree

Showing 3 changed files with 269 additions and 263 deletions.
diff --git a/extension.js b/extension.js
@@ -116,11 +116,7 @@ function getStyle(isIcon = false) {
 }
 
 function byteArrayToString(bytes) {
-    if (global.TextDecoder) {
-        return new TextDecoder().decode(bytes);
-    }
-
-    return imports.byteArray.toString(bytes);
+    return new TextDecoder().decode(bytes);
 }
 
 function initNsLabels() {
@@ -405,6 +401,15 @@ export default class NetSpeedSimplifiedExtension extends Extension {
     disable() {
         currentSettings = null;
         settings = null;
+
+        usLabel = null;
+        dsLabel = null;
+        tsLabel = null;
+        tdLabel = null;
+        usIcon = null;
+        dsIcon = null;
+        tsIcon = null;
+        tdIcon = null;
 
         GLib.source_remove(timeout);
         nsDestroy();

diff --git a/metadata.json b/metadata.json
@@ -7,5 +7,5 @@
   ],
   "url": "https://github.com/prateekmedia/netspeedsimplified",
   "uuid": "[email protected]",
-  "version": 40
+  "version": 41
 }