-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fresh work on nowrap cells #149
base: master
Are you sure you want to change the base?
Conversation
Based almost entirely on: prawnpdf#50 Implements the wrapping, adds no more failures (than the current master fails on 3.0.4 anyway), but adds new tests and documentation.
I took the work on #50, made it not fail any more tests than before, added new tests and docs. All seems "fine", except there's an additional border now, that I don't know how to get rid of! Any ideas @gettalong ? Thanks. |
@andyjeffries I'm not very acquainted with the prawn-table code but will have a look if I find some time. |
Thanks anyway @gettalong , I found it though. I was calling This is now ready for review and merging (ignoring the test that failed before this one) |
Just added |
@gettalong this is ready for review, but the request is blocked (I've been using it in production for six months now). Could you approve/review it? |
@andyjeffries I'm sorry but I currently don't have the time for that. |
Based almost entirely on:
#50
Implements the wrapping, adds no more failures (than the current master fails on 3.0.4 anyway), but adds new tests and documentation.