Identify sockets #177
Identify sockets #177
Conversation
identify/identify.py
Outdated
| return {DIRECTORY} | ||
| if os.path.islink(path): | ||
| return {SYMLINK} | ||
| if stat.S_ISSOCK(os.stat(path).st_mode): | ||
| return {SOCKET} |
There was a problem hiding this comment.
I wonder if we should do a single os.stat call and then decide based on that -- as it is right now this is going to do at least 4 stat calls to determine these tags
There was a problem hiding this comment.
Do you mean isdir, islink, and others do os.stat under the hood?
There was a problem hiding this comment.
For os.access do you recommend hand-rolling something that supports both posix & windows or leaving it as-is? Also for some of the public functions that check if a file exists & other properties, should I remove those checks (because the caller checks them) to save on stat calls, or preserve the behavior because they're public?
There was a problem hiding this comment.
Went with erring towards leaving more code as-is but lmk if there's anything else straightforward that I missed
This is part of #72