fix: Ensure preact is optimized by Vite
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
changed the title
preact is optimizedpreact is optimized by Vite
JoviDeCroock
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76
Corrects a rather bizarre HMR bug.
If the user doesn't directly import anything from
preact(as our prerender templates do not, instead pullinghydratefrompreact-iso), Vite won't optimize thepreactdependency (or won't do so in the same way, anyhow) and prefresh will fail to reload any components altered in a module outside of the root (e.g.,/src/components/*).Not quite sure why this is yet, but always optimizing preact shouldn't be a problem -- it'll always exist somewhere in the user's app, even if not directly used. Optimizing it won't be a waste.