Skip to content

Remove duplicate node version check and add type as Node | undefined to head #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nishan-singh
Copy link

I removed duplicated node source version check in needToRecompute func and make the head's type Node | undefined in cleanUpSources func.

Copy link

changeset-bot bot commented May 3, 2025

⚠️ No Changeset found

Latest commit: 285457c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented May 3, 2025

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 285457c
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/681624e0230a200008b88ccb
😎 Deploy Preview https://deploy-preview-674--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nishan-singh nishan-singh changed the title Remove duplicate node version check and add type as Node | undefined for head Remove duplicate node version check and add type as Node | undefined to head May 3, 2025
@JoviDeCroock
Copy link
Member

Your PR needs a changeset

@rschristian rschristian linked an issue May 3, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant condition in version check logic
2 participants