-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smarthub: renaming Smarthub to Attekmi #5699
base: master
Are you sure you want to change the base?
Smarthub: renaming Smarthub to Attekmi #5699
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also submit attekmi.md in this pr similar to this: https://github.com/prebid/prebid.github.io/pull/5704/files which documents a new alias
this means people will find your documentation no matter which name they look for and both names will appear on the download page
I agree with Patrick here. Renaming adapters is common, but can be confusing to publishers who can't find documentation for the name they're familiar with. The smarthub.md file can say "please note that SmartHub has been renamed to Attekmi" or something like that. |
I added attekmi.md and add note about rebranding in smarthub.md |
🏷 Type of documentation
📋 Checklist
We change the name from Smarthub to Attekmi but leave the biddercode 'smarthub'
Prebid.js PR prebid/Prebid.js#12432
Prebid-server PR prebid/prebid-server#4047