Bidtheatre Bidder Adapter: initial release, docs #5723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
muuki88
requested changes
Nov 25, 2024
| pbs_app_supported: true | ||
| --- | ||
|
|
||
| ### Registration |
There was a problem hiding this comment.
Suggested change
| ### Registration | |
| ### Registration | |
Weirdly markdownlint is not triggered. There must always be a new line after a heading
| - All ad slots on a page must belong to the same publisher ID | ||
| - The publisher must provide either a client IP and/or explicit geo data in the request | ||
|
|
||
| ### First Party Data |
There was a problem hiding this comment.
Suggested change
| ### First Party Data | |
| ### First Party Data | |
| - ortb2.site.* | ||
| - ortb2.user.* | ||
|
|
||
| ### ORTB Blocking |
There was a problem hiding this comment.
Suggested change
| ### ORTB Blocking | |
| ### ORTB Blocking | |
| ### ORTB Blocking | ||
| `bcat`, `badv` and `battr` are all supported. | ||
|
|
||
| ### Media Types |
There was a problem hiding this comment.
Suggested change
| ### Media Types | |
| ### Media Types | |
|
Minor nitpicking, rest looks good. |
muuki88
requested changes
Nov 25, 2024
dev-docs/bidders/bidtheatre.md
Outdated
Comment on lines
18
to
19
| pbs: true | ||
| pbs_app_supported: true |
There was a problem hiding this comment.
Prebid Server usually takes a lot longer to review. I would recommend setting those to false, as prebid.js is already merged.
You could open a second PR then for the PBS support.
This way you get the docs online faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist