Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not supporting adjustable timestep in .org since OpenFOAM 9 #261

Open
MakisH opened this issue Nov 19, 2022 · 0 comments
Open

Not supporting adjustable timestep in .org since OpenFOAM 9 #261

MakisH opened this issue Nov 19, 2022 · 0 comments
Labels
compatibility Affecting only specific OpenFOAM / preCICE versions

Comments

@MakisH
Copy link
Member

MakisH commented Nov 19, 2022

While rebasing the Foundation branches, I noticed that marking the function object methods as final caught an issue: OpenFOAM 9 (and newer) changed the function objects API, which was previously changed in OpenFOAM 6 (at least changes that affect the adapter).

 In file included from preciceAdapterFunctionObject.C:25:
preciceAdapterFunctionObject.H:137:10: error: ‘bool Foam::functionObjects::preciceAdapterFunctionObject::setTimeStep()’ marked ‘final’, but is not virtual
  137 |     bool setTimeStep() final;
      |          ^~~~~~~~~~~
make: *** [/opt/openfoam9/wmake/rules/General/transform:26: Make/linux64GccDPInt32Opt/preciceAdapterFunctionObject.o] Error 1

Compare OpenFOAM8 and OpenFOAM9.

I am removing this function for now. If someone is interested, reimplement.

@MakisH MakisH mentioned this issue Nov 19, 2022
42 tasks
@MakisH MakisH added the compatibility Affecting only specific OpenFOAM / preCICE versions label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Affecting only specific OpenFOAM / preCICE versions
Projects
None yet
Development

No branches or pull requests

1 participant