You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While rebasing the Foundation branches, I noticed that marking the function object methods as final caught an issue: OpenFOAM 9 (and newer) changed the function objects API, which was previously changed in OpenFOAM 6 (at least changes that affect the adapter).
In file included from preciceAdapterFunctionObject.C:25:
preciceAdapterFunctionObject.H:137:10: error: ‘bool Foam::functionObjects::preciceAdapterFunctionObject::setTimeStep()’ marked ‘final’, but is not virtual
137 | bool setTimeStep() final;
| ^~~~~~~~~~~
make: *** [/opt/openfoam9/wmake/rules/General/transform:26: Make/linux64GccDPInt32Opt/preciceAdapterFunctionObject.o] Error 1
While rebasing the Foundation branches, I noticed that marking the function object methods as
final
caught an issue: OpenFOAM 9 (and newer) changed the function objects API, which was previously changed in OpenFOAM 6 (at least changes that affect the adapter).Compare OpenFOAM8 and OpenFOAM9.
I am removing this function for now. If someone is interested, reimplement.
The text was updated successfully, but these errors were encountered: