-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.2.0 #257
Merged
Release v1.2.0 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… solver (#236) Co-authored-by: Philip Cardiff <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]>
…cement field (#241) Co-authored-by: Gerasimos Chourdakis <[email protected]>
co-authored-by: [email protected]
Co-authored-by: David Schneider <[email protected]>
* Inform user about WM_NCOMPPROCS, remove -j flag * Document WM_NCOMPPROCS * Add changelog entry * Add default value for unset WM_NCOMPPROCS Co-authored-by: David Schneider <[email protected]>
To circumvent wrong font issues
Co-authored-by: David Schneider <[email protected]>
* Implement a checkpoint reset functionality * Add more comments in the code as suggested in the review * Add documentation for the new option * Rename variable to restartFromDeformed * Restrict option to fluid solvers Co-authored-by: Gerasimos Chourdakis <[email protected]>
davidscn
approved these changes
Nov 14, 2022
Co-authored-by: David Schneider <[email protected]>
* Force: Distinguish between owning and non-owning Closes #259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small feature release, which mainly enables a few additional features:
pointDisplacement
Note that previously the adapter was always building with four threads by default. We now removed that strange assumption and documented the
WM_NCOMPPROCS
of OpenFOAM, instead.As always, there are also a few small improvements here and there, as well as more documentation. See the
CHANGELOG.md
for more.This release includes code contributions and reviews by the preCICE team (@MakisH, @davidscn, @fsimonis), as well as code contributions by @solids4foam.
Release checklist
Copy this template to the release pull request description.
Update workflows
.github/workflows/build.yml
and.github/workflows/install-dependencies.sh
: Update the OpenFOAM and preCICE versions, if needed.build-custom.yml
: Add any new OpenFOAM versions and update the default preCICE version, if needed.Prepare branches
master
todevelop
, if neededdevelop
tomaster
.Test
Until we get automated system tests again, run all the tests manually.
Preparing the Changelog
CHANGELOG.md
changelog-entries/
Bump the version
CHANGELOG.md
Adapter.C
(removing the+ unreleased changes
part).Merge
Prepare version-specific branches
OpenFOAM4
onmaster
and force-pushgit checkout OpenFOAM4 && git rebase develop
git push --force
OpenFOAM5
onOpenFOAM4
,OpenFOAM6
onOpenFOAM5
, ...std::make_unique
andstd::unique_ptr
, I replaced it withFoam::autoPtr
.clockValue
, I made also the header include optional. Will need to port to develop.Overview of branches:
Release
.git/
or.gitignore
) for each version and attach to the release. Use the linkhttps://github.com/precice/openfoam-adapter/archive/refs/heads/BRANCH.tar.gz
(substituteBRANCH
). Rename the folder in each archive to reflect the name of the archive.master
: archiveopenfoam-adapter_v1.0.0_OpenFOAMv1812-v2206-newer.tar.gz
(adjustv2206
to the latest supported, andv1.0.0
to the actual version)OpenFOAM4
: archiveopenfoam-adapter_v1.0.0_OpenFOAM4_5_v1806.tar.gz
OpenFOAM6
: archiveopenfoam-adapter_v1.0.0_OpenFOAM6_experimental.tar.gz
OpenFOAM7
: archiveopenfoam-adapter_v1.0.0_OpenFOAM7_experimental.tar.gz
OpenFOAM8
: archiveopenfoam-adapter_v1.0.0_OpenFOAM8_experimental.tar.gz
Post-release
master
todevelop
. No PR is needed for that.Loaded the OpenFOAM-preCICE adapter v1.0.0 + unreleased changes
.tools/release_pull_request_template.md
)and celebrate! 🎉 🍻