fix: satisfy when there is not pypi packages in the lockfile (#1862)

prefix-dev · Aug 21, 2024 · 7b92e25 · 7b92e25
1 parent 6e400fe
commit 7b92e25
Show file tree

Hide file tree

Showing 4 changed files with 450 additions and 6 deletions.
diff --git a/src/lock_file/satisfiability.rs b/src/lock_file/satisfiability.rs
@@ -258,9 +258,14 @@ pub fn verify_environment_satisfiability(
         let indexes = rattler_lock::PypiIndexes::from(grouped_env.pypi_options());
         match locked_environment.pypi_indexes() {
             None => {
+                // Mismatch when there should be an index but there is not
                 if locked_environment
                     .version()
                     .should_pypi_indexes_be_present()
+                    && locked_environment
+                        .pypi_packages()
+                        .iter()
+                        .any(|(_platform, packages)| !packages.is_empty())
                 {
                     return Err(IndexesMismatch {
                         current: indexes,

diff --git a/tests/add_tests.rs b/tests/add_tests.rs
@@ -2,6 +2,11 @@ mod common;
 
 use std::str::FromStr;
 
+use crate::common::{
+    builders::{HasDependencyConfig, HasPrefixUpdateConfig},
+    package_database::{Package, PackageDatabase},
+    LockFileExt, PixiControl,
+};
 use pixi::{DependencyType, Project};
 use pixi_consts::consts;
 use pixi_manifest::{pypi::PyPiPackageName, FeaturesExt, SpecType};
@@ -10,12 +15,6 @@ use serial_test::serial;
 use tempfile::TempDir;
 use uv_normalize::ExtraName;
 
-use crate::common::{
-    builders::{HasDependencyConfig, HasPrefixUpdateConfig},
-    package_database::{Package, PackageDatabase},
-    LockFileExt, PixiControl,
-};
-
 /// Test add functionality for different types of packages.
 /// Run, dev, build
 #[tokio::test]