-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add versions/build list to pixi search
output
#2440
Conversation
Thanks for this great improvement! This looks great already, what makes it draft for you? |
The PR still lacks adequate testing. I want to include that before marking it as ready to review. |
pixi search
output
@ruben-arts feel free to take a look! I'm a rust newbie, so please let me know if I'm violating any code conventions. |
Just FYI I also had a little stab at revamping the whole search topic here: #2390 If you want to incorporate anything from there, feel free! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I like the output improvements and the idea of the list of builds. The code looks good to me.
For the tests I would like to have them less hardcoded to make it more friendly to developers touching other parts of the code and then breaking these tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it! No more remarks
Motivation
Different to e.g.
micromamba search
,pixi search
does not provide information about other versions/builds of the found package (xref #378).Changes
Add versions/builds list for
pixi search
output.Joint work with @pavelzw.