Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add versions/build list to pixi search output #2440

Merged
merged 17 commits into from
Nov 19, 2024

Conversation

delsner
Copy link
Contributor

@delsner delsner commented Nov 8, 2024

Motivation

Different to e.g. micromamba search, pixi search does not provide information about other versions/builds of the found package (xref #378).

Changes

Add versions/builds list for pixi search output.

Joint work with @pavelzw.

@pavelzw
Copy link
Contributor

pavelzw commented Nov 8, 2024

pixi search polarify

image

pixi search conda-forge-pinning (long versions)

image

pixi search polars (multiple builds for newest version)

image

@ruben-arts
Copy link
Contributor

Thanks for this great improvement!

This looks great already, what makes it draft for you?

@delsner
Copy link
Contributor Author

delsner commented Nov 11, 2024

The PR still lacks adequate testing. I want to include that before marking it as ready to review.

@delsner delsner changed the title feat: Add versions/build list to pixi search output feat: Add versions/build list to pixi search output Nov 11, 2024
@delsner delsner marked this pull request as ready for review November 13, 2024 17:44
@delsner
Copy link
Contributor Author

delsner commented Nov 13, 2024

@ruben-arts feel free to take a look! I'm a rust newbie, so please let me know if I'm violating any code conventions.

@wolfv
Copy link
Member

wolfv commented Nov 13, 2024

Just FYI I also had a little stab at revamping the whole search topic here: #2390

If you want to incorporate anything from there, feel free! :)

@pavelzw
Copy link
Contributor

pavelzw commented Nov 13, 2024

@wolfv yes we plan to improve pixi search in a series of PRs to eventually have it in a way that we can close #378 :)

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I like the output improvements and the idea of the list of builds. The code looks good to me.

For the tests I would like to have them less hardcoded to make it more friendly to developers touching other parts of the code and then breaking these tests.

src/cli/search.rs Outdated Show resolved Hide resolved
@delsner delsner requested a review from ruben-arts November 19, 2024 10:58
Copy link
Contributor

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! No more remarks

@ruben-arts ruben-arts merged commit a642b35 into prefix-dev:main Nov 19, 2024
40 checks passed
@pavelzw pavelzw deleted the search-limit branch November 26, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants