Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pypi source dependencies #985

Merged
merged 37 commits into from
Mar 22, 2024

Conversation

tdejager
Copy link
Contributor

Add pypi source dependencies to pixi.

@baszalmstra baszalmstra changed the title Feat/pypi source dependencies feat: pypi source dependencies Mar 21, 2024
@tdejager tdejager marked this pull request as ready for review March 21, 2024 15:35
@wolfv
Copy link
Member

wolfv commented Mar 22, 2024

I removed the unwrap by removing the "Preference" stuff completely. It was always empty, and thus also completely untested. I think the way I serialized the hashes was also broken (it shoudl be something liek sha256:bla or similar.

Let's add it back in when we need it?

@ruben-arts ruben-arts enabled auto-merge (squash) March 22, 2024 12:04
@ruben-arts ruben-arts disabled auto-merge March 22, 2024 12:19
@ruben-arts ruben-arts merged commit c55708b into prefix-dev:main Mar 22, 2024
27 checks passed
@ruben-arts ruben-arts mentioned this pull request Mar 25, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants