Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

use http status codes #138

Merged
merged 1 commit into from
Sep 4, 2023
Merged

use http status codes #138

merged 1 commit into from
Sep 4, 2023

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl self-assigned this Sep 4, 2023
@casperdcl casperdcl added enhancement New feature or request python Pull requests that update Python code p2-nice-to-have Low priority labels Sep 4, 2023
@casperdcl casperdcl mentioned this pull request Sep 4, 2023
Closed
casperdcl
casperdcl commented Sep 4, 2023
View reviewed changes
app/routes.py
@@ -58,7 +59,7 @@ async def registries_all():
"/registries/",
response_model=schemas.RegistryResponse,
responses={
400: {
HTTPStatus.BAD_REQUEST: {
Copy link
Contributor Author

@casperdcl casperdcl Sep 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi since statuses are IntEnum, this change should be fine (no need to use HTTPStatus.BAD_REQUEST.value i.e. int explicitly)

>>> BAD_REQUEST == 400 == BAD_REQUEST.value
True

Janaka-Steph
Janaka-Steph approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Janaka-Steph Janaka-Steph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nsosio
nsosio approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@nsosio nsosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me :)

@casperdcl casperdcl merged commit 373beda into premAI-io:main Sep 4, 2023
1 check passed
@casperdcl casperdcl deleted the http-status_code branch September 4, 2023 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nsosio nsosio nsosio approved these changes

@Janaka-Steph Janaka-Steph Janaka-Steph approved these changes

@sekulicd sekulicd Awaiting requested review from sekulicd

@tiero tiero Awaiting requested review from tiero

@filopedraz filopedraz Awaiting requested review from filopedraz

Assignees

@casperdcl casperdcl

Labels
enhancement New feature or request p2-nice-to-have Low priority python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use http status codes
3 participants
@casperdcl @Janaka-Steph @nsosio