Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internalize use of icons in Spark. #140

Closed
WilliamKelley opened this issue Jul 12, 2021 · 1 comment
Closed

Internalize use of icons in Spark. #140

WilliamKelley opened this issue Jul 12, 2021 · 1 comment

Comments

@WilliamKelley
Copy link
Contributor

In #134, the declaration of the ChevronDown icon was moved from @prenda/spark to @prenda/spark-icons. As a result, @prenda/spark now uses (depends on) @prenda/spark-icons. This isn't a good standard.

  • Our core package depends on an auxiliary package.
  • If/when @prenda/spark develops a custom SvgIcon component (which I foresee happening) and it needs to be pulled into @prenda/spark-icons, then there will be a circular dependency. The resolution of which will be for Spark to internalize icon usage, or for Icons to copy and internalize a component -- I think the former is more acceptable.
This was referenced Jul 13, 2021
Closed
Merged
@WilliamKelley
Copy link
Contributor Author

Closed by #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WilliamKelley