-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spark)!: remove all Icons #134
Conversation
The deep imports are failing, looking into why Example error msg: ERROR in ./libs/spark/src/Select.ts
Module not found: Error: Can't resolve '@prenda/spark-icons/ChevronDown' in '/home/william/projects/spark/libs/spark/src'
@ ./libs/spark/src/Select.ts 1:0-62 5:17-32 Fixed by modifying |
d706beb
to
d489ca2
Compare
06f752b
to
f629c5e
Compare
- attribution given - no modifications made to ensure working order, purely copy-paste
- repo is broken because usage hasn't been changed
9c985cf
to
7a81514
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice. I appreciate you wading into Webpack config to get the imports working!
3 of 4
Part of #73. Last five commits are relevant. Reviewable by commit.
In this step
Removal and Replacement
All 1700 icon and index files were removed.
Only the icons we use in components/stories were generated and their usage replaced with deep imports -- we probably want to internalize to Spark whatever icons it uses, see #140 for discussion.