Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove spark-icons library #713

Merged
merged 1 commit into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 0 additions & 3 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
/libs/spark-icons/defaults/templateSvgIcon.js
/libs/spark-icons/src/*
/libs/spark-icons/custom
1 change: 0 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"error",
{
"enforceBuildableLibDependency": true,
"allow": ["@prenda/spark-icons", "@prenda/spark-icons/*"],
"depConstraints": [
{
"sourceTag": "*",
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/ci:main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,3 @@ jobs:

- name: Unit test project spark
run: npx nx run spark:test

- name: Unit test project spark-icons
run: npx nx run spark-icons:test
38 changes: 0 additions & 38 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,41 +62,3 @@ jobs:
MSG_MINIMAL: true
SLACK_TITLE: '@prenda/spark ${{ steps.get_version.outputs.VERSION }}'
SLACK_MESSAGE: Failed to publish

- name: Build @prenda/spark-icons
run: npm run build:icons
# see https://github.com/JS-DevTools/npm-publish/issues/15
env:
INPUT_TOKEN: ''

- name: Publish @prenda/spark-icons
uses: JS-DevTools/npm-publish@v1
with:
token: ${{ secrets.NPM_TOKEN }}
package: ./dist/libs/spark-icons/package.json

- name: Notify @prenda/spark-icons publish success
if: success()
uses: rtCamp/action-slack-notify@v2
env:
SLACK_CHANNEL: feed-design-system
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_COLOR: ${{ job.status }}
SLACK_ICON: https://github.com/prenda-school/prenda-spark/raw/main/public/img/prenda-design-system-abstract-mark-logo.svg
SLACK_USERNAME: 'Action: NPM Publish'
MSG_MINIMAL: true
SLACK_TITLE: '@prenda/spark-icons ${{ steps.get_version.outputs.VERSION }}'
SLACK_MESSAGE: Published

- name: Notify @prenda/spark-icons publish failure
if: failure()
uses: rtCamp/action-slack-notify@v2
env:
SLACK_CHANNEL: feed-design-system
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_COLOR: ${{ job.status }}
SLACK_ICON: https://github.com/prenda-school/prenda-spark/raw/main/public/img/prenda-design-system-abstract-mark-logo.svg
SLACK_USERNAME: 'Action: NPM Publish'
MSG_MINIMAL: true
SLACK_TITLE: '@prenda/spark-icons ${{ steps.get_version.outputs.VERSION }}'
SLACK_MESSAGE: Failed to publish
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,3 @@ testem.log
# System Files
.DS_Store
Thumbs.db

# @prenda/spark-icons Raw Downloads
/libs/spark-icons/svg-files
4 changes: 1 addition & 3 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/coverage
/dist
/libs/spark/public/fonts/**/LICENSE.(txt|md)
/libs/spark-icons/defaults/templateSvgIcon.js
/libs/spark-icons/src/*
/libs/spark/public/fonts/**/LICENSE.(txt|md)
1 change: 0 additions & 1 deletion .storybook/manager.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { create } from '@storybook/theming';
// Hierarchy naming described here: https://storybook.js.org/docs/react/writing-stories/naming-components-and-hierarchy . Limitation is that slashes ("/") cannot be used in a name, so we define some shorthand-mappings here (also these are just long).
const nameToLabel = {
'@ps': '@prenda/spark',
'@psi': '@prenda/spark-icons',
};

const config: Config = {
Expand Down
6 changes: 0 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@
Implementations are available as installable NPM packages:

- [@prenda/spark](https://www.npmjs.com/package/@prenda/spark)
- [@prenda/spark-icons](https://www.npmjs.com/package/@prenda/spark-icons)

```sh
npm i @prenda/spark @prenda/spark-icons
```

## Usage

Expand Down Expand Up @@ -70,7 +65,6 @@ Read the [contributing guide](/CONTRIBUTING.md) to learn about our development p
Read the changelog of each library to address breaking changes and learn about new features and fixes.

- [`@prenda/spark/CHANGELOG`](libs/spark/CHANGELOG.md)
- [`@prenda/spark-icons/CHANGELOG`](libs/spark-icons/CHANGELOG.md)

## No license

Expand Down
12 changes: 0 additions & 12 deletions libs/spark-icons/.babelrc

This file was deleted.

29 changes: 0 additions & 29 deletions libs/spark-icons/.eslintrc.json

This file was deleted.

46 changes: 0 additions & 46 deletions libs/spark-icons/BUILDER.md

This file was deleted.

Loading