Skip to content

Commit

Permalink
Fix native_expression.max_array_size_in_reduce session property
Browse files Browse the repository at this point in the history
  • Loading branch information
pdabre12 authored and tdcmeehan committed Oct 18, 2024
1 parent 47e3730 commit 0c19d4f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ public final class SystemSessionProperties

// TODO: Native execution related session properties that are temporarily put here. They will be relocated in the future.
public static final String NATIVE_SIMPLIFIED_EXPRESSION_EVALUATION_ENABLED = "native_simplified_expression_evaluation_enabled";
public static final String NATIVE_EXPRESSION_MAX_ARRAY_SIZE_IN_REDUCE = "native_expression.max_array_size_in_reduce";
public static final String NATIVE_EXPRESSION_MAX_ARRAY_SIZE_IN_REDUCE = "native_expression_max_array_size_in_reduce";
public static final String NATIVE_AGGREGATION_SPILL_ALL = "native_aggregation_spill_all";
public static final String NATIVE_MAX_SPILL_LEVEL = "native_max_spill_level";
public static final String NATIVE_MAX_SPILL_FILE_SIZE = "native_max_spill_file_size";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class SessionProperties {
/// Reduce() function will throw an error if it encounters an array of size
/// greater than this value.
static constexpr const char* kExprMaxArraySizeInReduce =
"native_expression.max_array_size_in_reduce";
"native_expression_max_array_size_in_reduce";

/// The maximum memory used by partial aggregation when data reduction is not
/// optimal.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ TEST_F(QueryContextManagerTest, nativeSessionProperties) {
{"native_debug_disable_expression_with_lazy_inputs", "true"},
{"native_selective_nimble_reader_enabled", "true"},
{"aggregation_spill_all", "true"},
{"native_expression.max_array_size_in_reduce", "99999"},
{"native_expression_max_array_size_in_reduce", "99999"},
}};
auto queryCtx = taskManager_->getQueryContextManager()->findOrCreateQueryCtx(
taskId, session);
Expand Down

0 comments on commit 0c19d4f

Please sign in to comment.