Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] Add session property native_writer_flush_threshold_bytes #23891

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[native] Add session property native_writer_flush_threshold_bytes #23891

merged 1 commit into from
Oct 29, 2024

Conversation

tanjialiang
Copy link
Contributor

@tanjialiang tanjialiang commented Oct 25, 2024 •
edited
Loading 

== RELEASE NOTES ==

Session changes
- Add session property: 'native_writer_flush_threshold_bytes' :pr:`23891 `

@tanjialiang tanjialiang requested review from a team as code owners October 25, 2024 23:00
xiaoxmeng
xiaoxmeng previously approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjialiang thanks!

steveburnett
steveburnett previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Thanks for the doc! Pull branch, local doc build, looks good.

steveburnett
steveburnett previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new doc build, looks good. Thanks!

xiaoxmeng
xiaoxmeng previously approved these changes Oct 29, 2024
View reviewed changes
@tanjialiang
Copy link
Contributor Author

LGTM! (docs)

Pull updated branch, new doc build, looks good. Thanks!

@steveburnett a rebase to resolve conflicts. Would you be able to give me another stamp? Thanks!

@gggrace14 gggrace14 self-requested a review October 29, 2024 19:00
steveburnett
steveburnett approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good.

@tanjialiang tanjialiang merged commit 4d0df87 into prestodb:master Oct 29, 2024
61 checks passed
@tanjialiang tanjialiang mentioned this pull request Oct 29, 2024
Merged
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
Merged
25 tasks
jaystarshot
jaystarshot reviewed Nov 4, 2024
View reviewed changes
presto-docs/src/main/sphinx/presto_cpp/properties-session.rst

Native Execution only. Enable writer spilling on native engine.
Minimum memory footprint size required to reclaim memory from a file writer by flushing its buffered data to disk.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding some info about the session properties to the release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaystarshot jaystarshot jaystarshot left review comments

@NikhilCollooru NikhilCollooru NikhilCollooru left review comments

@feilong-liu feilong-liu feilong-liu approved these changes

@steveburnett steveburnett steveburnett approved these changes

@gggrace14 gggrace14 gggrace14 approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

@elharo elharo Awaiting requested review from elharo elharo is a code owner

@xiaoxmeng xiaoxmeng Awaiting requested review from xiaoxmeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tanjialiang @gggrace14 @steveburnett @NikhilCollooru @jaystarshot @feilong-liu @xiaoxmeng