Drop getPreferredShuffleLayout methods from SPI #24106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use getNewTableLayout/getInsertLayout instead as they are expected to be mutually exclusive with getPreferredShuffleLayout*
Motivation and Context
The
preferredShuffleLayout
SPI was introduced as an experimental one. The optimizer expects eitherpreferredShuffleLayout
orgetInsertLayout
/getNewTableLayout
to return an non empty layout, but not both.Impact
Some custom connectors may need to apply a migration
Test Plan
CI
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.