Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop getPreferredShuffleLayout methods from SPI #24106

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

arhimondr
Copy link
Member

@arhimondr arhimondr commented Nov 20, 2024

Description

Use getNewTableLayout/getInsertLayout instead as they are expected to be mutually exclusive with getPreferredShuffleLayout*

Motivation and Context

The preferredShuffleLayout SPI was introduced as an experimental one. The optimizer expects either preferredShuffleLayout or getInsertLayout/ getNewTableLayout to return an non empty layout, but not both.

Impact

Some custom connectors may need to apply a migration

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

SPI Changes
* Remove experimental getPreferredShuffleLayout methods from the connector metadata in favor of existing `getNewTableLayout`, `getInsertLayout` methods :pr:`12345`

xiaoxmeng
xiaoxmeng previously approved these changes Nov 21, 2024
@tdcmeehan tdcmeehan added the from:Meta PR from Meta label Nov 22, 2024
@prestodb-ci
Copy link

Saved that user @arhimondr is from Meta

tdcmeehan
tdcmeehan previously approved these changes Nov 22, 2024
Use getNewTableLayout/getInsertLayout instead as they are expected to be
mutually exclusive with getPreferredShuffleLayout*
@arhimondr arhimondr merged commit 300ca07 into prestodb:master Nov 22, 2024
57 checks passed
@arhimondr arhimondr deleted the drop-preferred-writer-layout branch November 22, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants